Vector35 / Vector35/binaryninja-api
"e" to edit an instruction misaligned in graph view for basic blocks with tags
Open
Nobody has claimed this yet.
Component: UI
Effort: Trivial
Impact: Low
UI: Graph
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
The calculation that determines where the "edit text" dialog goes when editing an instruction in a basic block fails to account for the gutter when tags exist in a basic block:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the graph view code handling instruction editing in basic blocks, focusing on the calculation that positions the edit text dialog. Reproduce the issue with a tagged basic block and verify that the dialog is aligned after accounting for the gutter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100