Vector35 / Vector35/binaryninja-api
Typedef for structures makes stack view inconsistent
Open
Nobody has claimed this yet.
Component: UI
Effort: Low
Impact: Low
UI: Stack
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: 3.6.4712-dev Personal, 599e2ad7
- OS: macos
- OS Version: 14.1
- CPU Architecture: arm64
Bug Description:
In the image below you can see UNICODE_STRING and struct _UNICODE_STRING are actually same thing, but stack view does not thinks so.
Steps To Reproduce:
- Create a structure and a typedef for it
- Use that stucture and typedef in linear view
- Open stack view see the bug
Screenshots:
Typedef and structure:
typedef struct _UNICODE_STRING UNICODE_STRING;
struct _UNICODE_STRING
{
USHORT Length;
USHORT MaximumLength;
PWCH Buffer;
};
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in Binary Ninja by creating a structure and a typedef, using both in linear view, and opening stack view. Compare how UNICODE_STRING and struct _UNICODE_STRING are represented; done means the stack view treats the typedef and its structure as the same type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cpp
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100