Vector35 / Vector35/binaryninja-api

Incorrect outlining for format string

Open
#4,790 2 comments 2 reactions 1 assignee View on GitHub

@bpotchik is already working on this.

Since Dec 12, 2023.

Component: Core Effort: Medium Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 3.6.4690-dev Personal, 135d31cc
  • OS: Windows
  • OS Version: 11
  • CPU Architecture: x86_64

Bug Description:
In the screenshot below BN generates a _builtin_memcpy function for some weird stack data which is actually a format string if we look at the disassembly. I guess it should generate two separate _builtin_strcpy.

It also does not generates a strcpy for stack string TracerPid:.

Screenshots:

Additional Information:
I can share the BNDB in slack.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.