Vector35 / Vector35/binaryninja-api

Clicking "Set Variable Value" sometimes does nothing

Open
#4,786 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

The "Set Variable Value" action does not always produce the expected dialog. I would expect the menu item would be disabled if the variable I've selected is ineligible to have its value set.

Binary Ninja 3.6.4685-dev

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Binary Ninja 3.6.4685-dev with the "Set Variable Value" action, then locate the action's eligibility and dialog handling in the C++ implementation. Confirm the behavior for both eligible and ineligible variables; done means ineligible selections disable the menu item and eligible selections open the expected dialog.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.