Vector35 / Vector35/binaryninja-api

Incorrect function call reconstruction

Open
#4,655 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Platform Component: Type Libraries Effort: Low Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 3.6.4561-dev, 2d2336f2
  • OS: macos
  • OS Version: 13.6
  • CPU Architecture: arm64

Bug Description:
For a Decree binary LUNGE_00005_6, a function call is incorrectly reconstructed.
LUNGE_00005_6.gz

Steps To Reproduce:
Open LUNGE_00005_6, then show read_until function (with Medium Level IL view).

Expected Behavior:
Function call of receive at 0x080490aa, arg1(eax_1) and arg4(esi_1) should be transposed.

Screenshots:
2023-09-27 11 12 10

Additional Information:
Binary Ninja Version: 3.4.4271 worked correctly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the attached LUNGE_00005_6 binary in Binary Ninja 3.6.4561-dev and inspect the read_until function in Medium Level IL. Focus on the receive call at 0x080490aa and compare its argument reconstruction with Binary Ninja 3.4.4271; done means arg1 (eax_1) and arg4 (esi_1) are transposed correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.