"Patch"->"Convert To NOP" does not work on an invalid instruction

Open
#4,597 1 comment 0 reactions 1 assignee View on GitHub

@emesare is already working on this.

Since Jul 9, 2024.

Assessment

This issue has not been assessed yet.

Description

Component: UI Effort: Trivial Impact: Low

In the screenshot, BN fails to disassemble the bytes 0f 3f 07 0b.

Screenshot 2023-08-31 at 11 03 20 PM

When we try to do "Patch"->"Convert To NOP" on the line starting at 0x5, it does not work:

Screenshot 2023-08-31 at 11 03 48 PM

Pressing E to assemble the NOP instruction works fine

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.