Vector35 / Vector35/binaryninja-api

"e" after switching IL views selects the incorrect range

Open
#4,329 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Impact: Low UI: Linear
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Using "I" to switch between IL views, end up on disassembly and immediately hit "e". The broken behavior:

Screenshot 2023-05-21 at 11 27 16 AM

If you single click the selected line, the behavior is correct:

Screenshot 2023-05-21 at 11 27 46 AM

Note that the selection widget in the bottom shows the correct selection and address in either case.

Also, the broken behavior only occurs in linear view, not graph view.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the sequence by switching IL views with "I", opening disassembly in linear view, and pressing "e"; compare it with a single click on the selected line and with graph view. Trace the selection and address used by the "e" action after view switching, then verify that the selected range is correct in all three cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.