Vector35 / Vector35/binaryninja-api

Support creation of structure inside structures in types sidebar

Open
#4,121 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Medium UI: Types
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Most of the time I encounter a structures that have another structure in it whose members become visible over time. In the example below, I know that at offset 0x10 of wsa_ctx there is another structure that holds data buffer which have 2 four bytes member. In this case, I want to select both data and field_14 and create a structure there by pressing S.

Currently, BN creates a stucture with no members and do not modify wsa_ctx. I expect BN creates that structure, put it in the wsa_ctx's offset 0x10 and get rid of data and field_14.

Recording 2023-03-20 at 14 37 40

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the types sidebar and reproduce the case by selecting data and field_14 at offset 0x10 in wsa_ctx, then pressing S. Done means the selected members are replaced by a populated nested structure assigned at that offset, rather than creating an empty structure without modifying wsa_ctx.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.