Accept file drop events when loading begins, not after

Aperta
#4,111 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
cpp, macos
Ambito
desktop

Direzione di ricerca

Start by locating the macOS file-drop handling path in Binary Ninja and trace when the drop event is acknowledged relative to file loading. Reproduce with a large bndb or binary, then verify that the event is accepted as soon as parsing can be attempted rather than after loading completes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Component: UI Effort: Trivial Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 3.4.4149-dev
  • OS: macOS
  • OS Version: 12.4
  • CPU Architecture: M1

Bug Description:
When you drag and drop a file onto binja, the os event for dropping the files is not accepted until the file loads successfully. This is done to not accept drops of files that cannot be loaded. For small files, this is not an issue, but for larger files, this leaves your file browser ui waiting as it is stuck in the drag sequence. On macos, this effectively freezes finder until it times out after like 15 seconds. Binja should accept the drop event immediately if the file can even try to be parsed, as waiting too long looks like the file could not be parsed anyway.

Steps To Reproduce:

  1. Open binja
  2. Find a large file in finder (like a huge bndb or binary)
  3. Drag and drop into binja
  4. Observe file drag event get very stuck

Expected Behavior:
I expected drag and drop events to not time out

Additional Information:
Might only be a macOS behavior. I haven't tested on other platforms.

Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Vector35/binaryninja-api

Tutte le issue di Vector35/binaryninja-api

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.