Vector35 / Vector35/binaryninja-api

Changing font size does not immediately change the size of tags in the view

Open
#3,861 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low UI: Fonts
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 3.3.4025-dev, 5ab69587
  • OS: macOS
  • OS Version: 13.2
  • CPU Architecture: M1

Bug Description:
When we change the view font size (ui.font.view.size), the font size of the disassembly text changes properly. But the size of the tags are not changed accordingly. The tag size will be fine after we restart Binary Ninja.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open a binary
  2. Add a tag/bookmark
  3. Open settings
  4. Change ui.font.view.size
  5. Observe the size of the tag remain unchanged

Expected Behavior:
The size of the tag changes accordingly, immediately after the font size change.

Screenshots:

Screenshot 2023-02-03 at 5 23 52 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Binary Ninja on macOS: open a binary, add a tag or bookmark, then change ui.font.view.size in Settings. Inspect the view-font update path and tag rendering behavior. Done means tag text resizes immediately without restarting Binary Ninja, while disassembly text continues to update correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop, reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.