A large set of 1 byte strings can be improperly inlined as wchar16 strings

Open
#3,494 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
reverse-engineering

Research direction

Start by reproducing the issue with the contiguous single-byte, null-terminated strings described in the report on Binary Ninja 3.1.3178, then locate the string heuristics that accept the sequence as wchar16. Done means these strings are no longer inlined as the wrong string type while valid wchar16 strings continue to be recognized.

Written by the indexing model from the issue text.

Description

Component: Core Effort: Low Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 3.1.3178

Bug Description:
ascii strings shorter than 4 characters fail the string heuristic, but >4 contiguous single byte null-terminated strings pass the wchar16 heuristic, causing it to be inappropriately inlined as the wrong string type.

Screenshots:
From user:
image
image

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.