Vector35 / Vector35/binaryninja-api

MultilineTextInput sized poorly in get_form_input

Open
#3,485 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Trivial Impact: Low UI: Dialogs
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

Version and Platform (required):

  • Binary Ninja Version: 3.1.3704

Steps To Reproduce:

input = MultilineTextField('Test Multiline')
get_form_input([input], 'Test')

I suspect this is a QT change somewhere in the last few years as I know this worked better in the past.

Expected Behavior
Screen Shot 2022-09-23 at 12 04 45 PM

Actual Behavior
Screen Shot 2022-09-23 at 12 04 56 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with MultilineTextField('Test Multiline') and get_form_input([input], 'Test'). Start by locating the get_form_input and MultilineTextField implementations and checking their sizing behavior. Done means the multiline input has the expected larger dimensions shown in the issue rather than the narrow actual layout.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.