Vector35 / Vector35/binaryninja-api
update define name dialog to warn about shadowing
Open
Nobody has claimed this yet.
Component: UI
Effort: Trivial
Impact: Low
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
The "Define Name" dialog can be used to change either local variables, global variables, or function names, and it would be helpful if it could warn depending on the context of what is being changed if the new name would shadow another symbol.
- local variables
- global variables
- functions
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Define Name dialog implementation and trace the existing local-variable shadowing warning. Extend the behavior for global variables and function names, then verify that each context warns when the proposed name shadows another symbol and that the checked local-variable case remains covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools, reverse-engineering
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100