override call type does not override named parameters

Open
#3,412 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp

Research direction

Reproduce the issue using the five listed steps and the "override call type" action; no source file or test is named in the report. Trace how the overridden parameter names are propagated to the displayed call, and inspect related issue #2076. Done means the overridden names appear at the call site and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Description

Component: Core Effort: Trivial Impact: Low

Version and Platform (required):

  • Binary Ninja Version: 3.1.3626 and earlier
  • OS: Any

Bug Description:
Using the "override call type" ignores the new names.

Steps To Reproduce:

  1. Create a type for a function.
  2. Find a call and observe it will be like fn(argname: var1, argname2: var2) (depending on the call type)
  3. Now go "override call type" to be fn(int othername, int othername2)
  4. Expected behavior would be the call would now look like: fn(othername: var1, othername2: var2)
  5. It is not.

Expected Behavior:
On step 5, you should see the new names.

Additional Information:
This /may/ be related to #2076 so linking it here, but not sure.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.