Vector35 / Vector35/binaryninja-api
Inconsistent text filter behavior
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Right now, we have multiple widgets that support filtering of the items. However, there behaviors are not consistent. In particular, all widgets that inherit from FilterTarget class, i.e., those in the side bar are doing a plain text match. However, xref and search result is doing a regular expression match. I suggest we unify the behavior, e.g., also migrate FilterTarget to regular expression matching.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FilterTarget class and the sidebar widgets that inherit from it, then compare their matching behavior with the xref and search-result widgets described in the issue. Determine the intended common matching semantics and make the filtering behavior consistent across those widgets; done means equivalent text queries produce the same kind of matches everywhere.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, reverse-engineering
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100