Vector35 / Vector35/binaryninja-api
Changing variable name vs type can be confusing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Modal dialogs for change type and change name are not a great solution because once the dialog is up the user looses context of what they triggered the dialog on. Additionally users frequently hit "N" to rename instead of "Y" which allows them to set the type AND name.
Suggestion on how to fix:
- Implement a non-modal edit box which appears below the variable/function being renamed/re-typed. This will make it impossible for the user to loose the context of the item they're changing.
- Combine the rename and retype features into a single solution. 'N' and 'Y' would both show the name and type. 'N' would have the name selected. 'Y' would have the type selected. But both name and type could be changed.
- The thing being changed should be very obvious.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Begin by locating the existing modal change-type and change-name UI, then assess the requested inline combined editor; done means the edited variable or function remains obvious and both its name and type can be changed from either shortcut.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100