Vector35 / Vector35/binaryninja-api
Tag Type Notifications
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Version and Platform (required):
- Binary Ninja Version: dev
Bug Description:
When creating a new tag type, BN issues multiple separate update notifications. 1) when the name is set 2) when the icon is set, and 3) when the tag is "added". A user has to de-duplicate these notifications themselves using a separate list of "already processed" tag types.
Steps To Reproduce:
- Create a class that inherits BinaryDataNotification and register with the binary view.
- Add a new tag type - either manually or via API.
Expected Behavior:
A single notification when a new tag type is added to the binary view (versus an update notification for every piecemeal change to a tag type even before it's added).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing BinaryDataNotification handling for tag types and the binary view, including the manual and API creation paths described in the reproduction steps. The change is complete when creating a tag type produces one notification after it is added, rather than separate notifications for setting its name, icon, and addition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100