Vector35 / Vector35/binaryninja-api

IL annotations should generally be inlined

Open
#2,573 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Medium Impact: Medium
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

There is different logic applied to whether we show annotations such as strings at the end of a line as an annotation versus inlined into an expression in IL.

We can produce better IL results if we are more aggressive about inlining annotations and either replacing in the case of constant data or even just annotating but inside of the appropriate expression in the cases of mutable data where we want to still indicate it can change.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the IL annotation rendering logic and compare how constant and mutable annotations are handled. Done means annotations are inlined into the appropriate expressions, with constant data replaced and mutable data still identified as changeable.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.