Vector35 / Vector35/binaryninja-api

Linear View: Selecting an item in array of struct has incorrect selection region

Open
#2,179 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: UI Effort: Low Impact: Low UI: Linear
Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Description

This only seems to apply for structs which contain an array of structs. Linear View does not traverse the array to make the selected region only contain the selected line(s).

Selecting any element in the array in the example yields a selection region of all 8 items in the array. Expected behavior would be for the selection to only contain the one selected item.

Example: test.bndb.zip
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by opening the provided test.bndb.zip in Binary Ninja and reproducing the selection behavior in Linear View. Trace how selection regions are computed for arrays of structs, then verify that selecting an element includes only the selected line rather than all eight array items.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
reverse-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.