Vector35 / Vector35/binaryninja-api
Feature request: Bookmarks not saved with the current view.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 298
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 19
Description
Binary Ninja Version: 2.1.2263 Personal, 4d2bf25a
Platform: Windows 10 Version 2004
Description
When saving a bookmark the current view where the bookmark was made it's not saved. When saving a bookmark at the Disassembly view and switched to HLIL back, it doesn't appear. Saving a bookmark in HLIL switching back to one of the other views i.e MLIL it's selecting the wrong line. The preview of the bookmark shows the wrong instruction, also.
Problem statement
This makes bookmark saving inconsistency because you have to make sure to save a bookmark in the Disassembly because the preview of the bookmark can also be wrong.
Suggest a Feature
Adding a bookmark, the current view should be saved, also. The preview window shows the instruction for the view and by clicking on the bookmark it should switch the view and jump at the address.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported steps by saving bookmarks in Disassembly and HLIL, then switching to HLIL or MLIL and checking the preview and selected line. Trace how bookmark view state is saved and restored; done means a bookmark preserves its originating view, shows the matching instruction, and returns to that view and address when selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop-dev, reverse-engineering
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100