Vector35 / Vector35/Z80

test_disasm.py: stale golden file stops the test at 6% coverage

Open Beginner friendly
#20 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
12
Forks
5
PR merge metrics
No merged PRs in 30d

Description

test_disasm.py fails early on 10 80:

10800000 DJNZ 0xff82
expected DEFB $10,$80

The plugin looks correct here — DJNZ with displacement -128 wraps to 0xff82 — so the expectation in disasm65536.txt is stale. Because the test bails on first mismatch, only about 6% of the 65536 encodings are actually checked today.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test_disasm.py and the failing 10 80 case, then inspect the corresponding entry in disasm65536.txt. Run the disassembly test to confirm the stale expected output is the only mismatch and that it proceeds beyond 6% coverage. Done means the full 65536-encoding check completes without mismatches.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.