INC writes no flags
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
OP.INC in Z80IL.py never passes a flags= argument, so 04 (INC B) lifts as plain B = B + 1.
On the Z80, INC sets S, Z, H, P/V and clears N (it leaves only C alone). OP.DEC already does this correctly with flags="not_c", so INC should use the same write type.
369 INCs in one test binary, none of them setting flags.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Z80IL.py and compare the OP.INC implementation with OP.DEC, which already uses flags="not_c". Check the lifting of the test binary's 369 INC instructions, and consider the issue done when INC updates the documented flags while preserving carry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- reverse-engineering
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 86/100