ValveSoftware / ValveSoftware/wine

5.13 doesn't build with the tests enabled

Open
#98 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2k
Forks
488
PR merge metrics
No merged PRs in 30d

Description

Caused by 289f450b5cf6 ("mmdevapi: Implement ActivateAudioInterfaceAsync.")

Looks like we are missing two other patches from the upstream:

  • 6e09636f68c3 ("include: Split objidl.idl to objidlbase.idl.")
  • cdf013b9b984 ("include: Add IAgileObject to objidlbase.idl.")

Then 29ccc21a4b4c ("windows.globalization: Add stub dll.") needs a small fixup:

diff --git a/dlls/windows.globalization.dll/windows.globalization_main.c b/dlls/windows.globalization.dll/windows.globalization_main.c
index f29079d6a5e..e6bba5e096f 100644
--- a/dlls/windows.globalization.dll/windows.globalization_main.c
+++ b/dlls/windows.globalization.dll/windows.globalization_main.c
@@ -25,7 +25,6 @@ static const char *debugstr_hstring(HSTRING hstr)

 DEFINE_GUID(IID_IGlobalizationPreferencesStatics,0x01bf4326,0xed37,0x4e96,0xb0,0xe9,0xc1,0x34,0x0d,0x1e,0xa1,0x58);
 DEFINE_GUID(IID_IVectorView,0xbbe1fa4c,0xb0e3,0x4583,0xba,0xef,0x1f,0x1b,0x2e,0x48,0x3e,0x56);
-DEFINE_GUID(IID_IAgileObject,0x94ea2b94,0xe9cc,0x49e0,0xc0,0xff,0xee,0x64,0xca,0x8f,0x5b,0x90);
 DEFINE_GUID(IID_IInspectable,0xaf86e2e0,0xb12d,0x4c6a,0x9c,0x5a,0xd7,0xaa,0x65,0x10,0x1e,0x90);

 typedef struct IVectorView IVectorView;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the three referenced upstream patches and the existing changes around mmdevapi and the Windows globalization stub. Inspect dlls/windows.globalization.dll/windows.globalization_main.c, including the shown duplicate IID_IAgileObject definition. Done means version 5.13 builds successfully with tests enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.