ValveSoftware / ValveSoftware/wine
Adopt ddraw-Rendering_Targets patch from staging
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 2k
- Forks
- 488
- PR merge metrics
- No merged PRs in 30d
Description
Apparently, many old DX3-7 games rely on being able to create a rendering target in system memory rather than video memory, and mainline Wine does not support that. This patch from Staging solves this issue by creating the render target in video memory instead.
Some notable games that depend on this according to WineHQ: *The Sims, Zoo Tycoon, TOCA Touring Car Championship, Conquest: Frontier Wars (the latter is available on Steam and has a demo)
However, there might be many more games out there that depend this feature, there are just the ones that were reported to use it.
I can personally confirm that it works very well with The Sims and that game was stable for hours and hours.
The patch: https://github.com/wine-staging/wine-staging/tree/master/patches/ddraw-Rendering_Targets
The WineHQ issue: https://bugs.winehq.org/show_bug.cgi?id=34906
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked wine-staging ddraw-Rendering_Targets patch and WineHQ issue 34906 to understand the requested behavior. Compare the patch with this repository's DirectDraw implementation, then verify the change against the reported games, including The Sims and Conquest: Frontier Wars.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100