ValveSoftware / ValveSoftware/wine
Handle ALG_ID_ECDH_P384 in BCryptGenerateKeyPair to make Anno 1800 Multiplayer work
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 2k
- Forks
- 488
- PR merge metrics
- No merged PRs in 30d
Description
Anno 1800 Multiplayer uses ALG_ID_ECDH_P384 in BCryptGenerateKeyPair when accepting an invite to a Multiplayer Game via Ubisoft Connect and fails with connection error LR05 if it is not handled.
Handling this case in the function seems to make it work (can start and see other player's actions in the game), although I'm not sure if anything else is required here or if the case was just forgotten.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in dlls/bcrypt/bcrypt_main.c at the BCryptGenerateKeyPair implementation around line 1713, and compare how the existing algorithm identifiers are handled. Confirm that ALG_ID_ECDH_P384 is accepted and verify the Anno 1800 multiplayer invite flow no longer fails with connection error LR05; the issue does not name a test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100