ValveSoftware / ValveSoftware/Proton

Build Issue on Ubuntu [Blocks bisecting process]

Open
#6,574 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
32.8k
Forks
1.6k
PR merge metrics
PR metrics pending

Description

The purpose of fixing this experimental build
From NVIDIA's internal benchmark report, we found out there is 10% performance regression by upgrading experimental-6.3-20220119 to experimental-7.0-20221012. So, I'm bisecting between the 2 tags to find what commit caused this regression on NVIDIA GPU.

Is there a way I can find the commit caused this regression from 6.3 to 7.0 without compiling experimental-6.3-20220119?

Steps to reproduce:

  1. Checkout to detached HEAD experimental-6.3-20220119
  2. update submodule: git submodule update --init --recursive
  3. make and cd to building folder mkdir xxx && cd xxx
  4. configure: ../configure.sh --container-engine=podman --enable-ccache --build-name=my_build
  5. run make, then I got the following errors. This error only happens on proton 6.3
make[1]: Leaving directory '/root/proton/xxx/obj-wine32'
touch /root/proton/xxx/.wine-build32
make: Leaving directory '/root/proton/xxx'
make[1]: *** [../build/makefile_base.mak:117: container-build] Error 2
make[1]: Leaving directory '/root/proton/xxx'
make: *** [../build/makefile_base.mak:32: nested_make] Error 2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the experimental-6.3-20220119 checkout with git submodule update --init --recursive, ../configure.sh --container-engine=podman --enable-ccache --build-name=my_build, and make. Start by reading the container-build and nested_make targets referenced in build/makefile_base.mak; done means the reported Proton 6.3 build completes and the bisecting process is no longer blocked.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, git
Domain
build-system, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.