ValveSoftware / ValveSoftware/Proton
Patch backport request: `kernel32/profile: Trim spaces from section names on load.`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 32.8k
- Forks
- 1.6k
- PR merge metrics
- PR metrics pending
Description
Feature Request
I confirm:
- that I haven't found another request for this feature.
- that I have checked whether there are updates for my system available that
contain this feature already.
Description
The following patch was recently added to upstream Wine: https://gitlab.winehq.org/wine/wine/-/commit/8d9eb707c61455583a42891d6841ba9feeaf78d3
This patch fixes an issue where INI files with extra spaces in the section names won't load. This affects the TMUnlimited mod for TrackMania Nations Forever (11020) and TrackMania United Forever (7200). Before the patch, it was impossible to change settings in the mod, as the INI would always fail to read. It's very possible that other software could also be affected by this bug, though I don't know of any at the moment.
Justification [optional]
Patch is already upstreamed, it would be nice to be able to just use Proton via Steam rather than manually launching the game using stock Wine or waiting until the eventual re-base of Proton.
Risks [optional]
Basically none
References [optional]
https://gitlab.winehq.org/wine/wine/-/commit/8d9eb707c61455583a42891d6841ba9feeaf78d3
https://bugs.winehq.org/show_bug.cgi?id=53814
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review upstream Wine commit 8d9eb707c61455583a42891d6841ba9feeaf78d3 and Wine bug 53814 first. Then locate the corresponding Proton kernel32/profile integration and verify that INI files with extra spaces in section names load for the cited TrackMania mods; done means the upstream behavior is available in Proton.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100