ValveSoftware / ValveSoftware/Proton

Proton logfiles contain the users steam id, and they probably shouldn't?

Open
#5,484 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
32.8k
Forks
1.6k
PR merge metrics
PR metrics pending

Description

Hi,

I noticed that proton logs that are created with the launcher option PROTON_LOG=1 contain the steam user id. This is the case for Proton 5.0, 5.13, 6.3.8. I didn't check older versions.

All the logs have this line:
Steam_SetMinidumpSteamID: Caching Steam ID: [17_DIGIT_STEAM_USER_ID] [API loaded no]
which contains the actual users id, so it's trivial to find the profile behind the report by visiting https://steamcommunity.com/profiles/[17_DIGIT_STEAM_USER_ID].

This connects the users id to their system information, hardware, kernel, etc, which is listed in the proton.log. It also connects steam accounts to github profiles (and every other forum profile where people post these logs).

Many people won't care about this, but for some this is probably an unexpected side effect of sharing a proton-logfile.

This also opens a way for scammers, acting as developers who were notified by Valve that the user had a problem with Proton. If the user has no idea that the proton.log they posted 'anonymously' actually contains their steam id and identifies them, a story like this might sound plausible. How should the 'developers' know otherwise?

I get that adding the users id might be useful for minidumps that are send to developers without ever being posted in a public space. That's fine. But for the logs that are shared here on github? Please correct me if I'm wrong, but I can't imagine it's really necessary to add the users steam id to the proton.logs. All the actually relevant and useful information about the users system should be already logged into it.

So, unless it's really useful, maybe you could just remove the user_steam_ids from the logs? Or at least make it more obvious that these logs contain the user information?

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with PROTON_LOG=1 and inspect the generated proton.log for the Steam_SetMinidumpSteamID line. Trace where that log entry is produced, then determine whether the Steam ID can be omitted from Proton logs or clearly flagged as identifying information. Done means the privacy concern is addressed and the resulting log behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.