ValveSoftware / ValveSoftware/Proton
Arguments do not work as expected
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 32.8k
- Forks
- 1.6k
- PR merge metrics
- PR metrics pending
Description
Proton 5.0-1
OS: Linux
I am doing some testing on the Proton script. And found that, when the line
self.run_proc([g_proton.wine_bin, "steam"] + sys.argv[2:] + self.cmdlineappend)
is invoked, if the sys.argv[2:] is more than one argument, then the process doesn't run. This is not happening in 4.11-2 version.
Looks like the steam argument after wine (g_proton.wine_bin) causes the issue in 5.0-1. Removing the steam, then the process can run with argument.
Steps to re-produce
- Create a directory
/tmp/proton_test - Run the following script,
#!/bin/bash
export STEAM_COMPAT_DATA_PATH="/tmp/proton_test"
export WINEPREFIX="/tmp/proton_test/pfx"
export PATH="$HOME/.steam/steam/steamapps/common/Proton 5.0/dist/bin:$PATH"
export LD_LIBRARY_PATH="$HOME/.steam/steam/steamapps/common/Proton 5.0/dist/lib:$HOME/.steam/steam/steamapps/common/Proton 5.0/dist/lib64:$LD_LIBRARY_PATH"
export WINEDLLPATH="$HOME/.steam/steam/steamapps/common/Proton 5.0/dist/lib/wine/fakedlls:$HOME/.steam/steam/steamapps/common/Proton 5.0/dist/lib64/wine/fakedlls"
"$HOME/.steam/steam/steamapps/common/Proton 5.0/proton" run notepad test.txt
- Nothing shown.
If change to Proton 4.11, the test.txt will be open by notepad.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Proton script's run_proc invocation shown in the report and compare its argument handling with Proton 4.11-2. Reproduce the provided /tmp/proton_test command with multiple arguments, then verify that Proton 5.0-1 launches notepad and opens test.txt as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, linux, python
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100