Buffer overflow on exit for DS3, DS2:SOTFS, DS2, DS1: Prepare to Die (374320, 335300, 236430, 211420)

Description of issue:

When running Steam from the terminal, these Dark Souls games have a buffer overflow when exiting the game:

• DARK SOULS™ III (374320)
• DARK SOULS™ II: Scholar of the First Sin (335300)
• DARK SOULS™ II (236430)
• DARK SOULS™: Prepare To Die Edition (211420)

Did not test: DARK SOULS™: REMASTERED (570940), I don't have this game. So I don't know if the remaster has this issue too...

Other games do not register a buffer overflow when exiting the game:

• The Awesome Adventures of Captain Spirit (845070)
• Sid Meier's Pirates! (3920)
• Airport Madness: World Edition (369290)

System Information

• OS: Ubuntu 18.04.1 LTS
• GPU: Nvidia GeForce GTX 780 Ti
• Driver/LLVM version: Nvidia 410.73
• Kernel version: 4.15.0-39-generic
• Link to full system information report as Gist.
• Proton version: 3.16-4 Beta
• Controller used: Wireless controller for XBOX One, model 1708, used wired via USB cable.

---

DARK SOULS™ III (374320) Buffer overflow.

steam-374320.log

Steps to reproduce DS3:

1. Start Steam client from within terminal.
2. Start DS3 by clicking on run.
3. View the intro splash screens.
4. Press A on "Press any button" prompt.
5. Press A on "Patch notes information" prompt.
6. Press D-pad up to select Quit.
7. Press A to exit game. (Quit)
8. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 10:49:41] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 10:49:41] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 10:49:41] Verifying installation...
[2018-11-16 10:49:41] Verification complete
*** buffer overflow detected ***: Z:\home\giraffe\.steam\steam\steamapps\common\DARK SOULS III\Game\DarkSoulsIII.exe terminated
[2018-11-16 10:50:40] Shutdown

---

DARK SOULS™ II: Scholar of the First Sin (335300) Buffer overflow.

steam-335300.log

Steps to reproduce DS2:SOTFS:

1. Start Steam client from within terminal.
2. Start DS2:SOTFS by clicking on run.
3. View the intro splash screens.
4. Press A to start game.
5. Press A to go past the "No new messages." message.
6. Press D-pad up to select Quit.
7. Press A to exit game. (Quit)
8. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-03 18:18:58] Startup - updater built Nov  2 2018 23:16:17
[2018-11-03 18:18:58] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-03 18:18:58] Verifying installation...
[2018-11-03 18:18:58] Verification complete
*** buffer overflow detected ***: Z:\home\giraffe\.steam\steam\steamapps\common\Dark Souls II Scholar of the First Sin\Game\DarkSoulsII.exe terminated
[2018-11-03 18:20:32] Shutdown

---

DARK SOULS™ II (236430) Buffer overflow.

steam-236430.log

Steps to reproduce DS2:

1. Start Steam client from within terminal.
2. Start DS2 by clicking on run.
3. Press A to get past the "This game uses autosave" message.
4. View the intro splash screens.
5. Press A to close the welcoming messages.
6. Press D-pad up to select Quit.
7. Press A to exit game.
8. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 15:13:06] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 15:13:06] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 15:13:06] Verifying installation...
[2018-11-16 15:13:06] Verification complete
*** buffer overflow detected ***: /home/giraffe/.steam/steam/steamapps/common/Dark Souls II/Game/DarkSoulsII.exe terminated
[2018-11-16 15:13:54] Shutdown

---

DARK SOULS™: Prepare To Die Edition (211420) Buffer overflow.

steam-211420.log

Steps to reproduce DS: Prepare To Die:

1. Start Steam client from within terminal.
2. Start DS: Prepare To Die by clicking on run.
3. Press A to go past the "This game uses autosave message".
4. View intro splash screens.
5. On main menu, press up on the D-pad twice to select Quit.
6. Press A to quit.
7. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 11:40:46] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 11:40:46] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 11:40:46] Verifying installation...
[2018-11-16 11:40:46] Verification complete
*** buffer overflow detected ***: /home/giraffe/.steam/steam/steamapps/common/Dark Souls Prepare to Die Edition/DATA/DARKSOULS.exe terminated
[2018-11-16 11:41:31] Shutdown

---

The Awesome Adventures of Captain Spirit (845070) No buffer overflow.

steam-845070.log

Steps to reproduce Captain Spirit:

1. Start Steam client from within terminal.
2. Start Captain Spirit by clicking on run.
3. View the intro splash screens.
4. Use A to get to the main menu.
5. Press D-pad up to select quit.
6. Press A twice (once to select quit, once to really quit).
7. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 10:58:48] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 10:58:48] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 10:58:48] Verifying installation...
[2018-11-16 10:58:48] Verification complete
[2018-11-16 10:59:52] Shutdown

---

Sid Meier's Pirates! (3920) No buffer overflow:

steam-3920.log

Steps to reproduce Sid Meier's Pirates!:

1. Start Steam client from within terminal.
2. Start Sid Meier's Pirates! by clicking on run.
3. View the intro splash screens.
4. When the main menu is loaded, use the mouse to exit the game.
5. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 11:19:51] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 11:19:51] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 11:19:51] Verifying installation...
[2018-11-16 11:19:51] Verification complete
[2018-11-16 11:20:27] Shutdown

---

Airport Madness: World Edition (369290) No buffer overflow:

steam-369290.log

Steps to reproduce Airport Madness: World Edition:

1. Start Steam client from within terminal.
2. Start Airport Madness: World Edition by clicking on run.
3. From the main menu use the mouse to click on Exit.
4. Exit Steam.

Terminal output:

Running Steam on ubuntu 18.04 64-bit
STEAM_RUNTIME is enabled automatically
Pins up-to-date!
[2018-11-16 11:29:54] Startup - updater built Nov 10 2018 02:44:20
[2018-11-16 11:29:54] Opted in to client beta 'publicbeta' via beta file
You are in the 'publicbeta' client beta.
[2018-11-16 11:29:54] Verifying installation...
[2018-11-16 11:29:54] Verification complete
[2018-11-16 11:30:08] Shutdown

---

The issue provides no source file or test entry point; begin with the linked steam-*.log files and reproduce the exit sequence on the listed Proton and game combinations. Done means the affected games exit without the reported buffer-overflow termination, while the comparison games remain unaffected.