ValveSoftware / ValveSoftware/GameNetworkingSockets
Undefined behavior in Plat_IsInDebugSession
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 9.9k
- Forks
- 749
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Description
Hello,
While debugging the PlayStation build, we noticed undefined behavior in Plat_IsInDebugSession. It seems that the NDA material has been removed but is missing a replacement in the ps5 project.
https://github.com/ValveSoftware/GameNetworkingSockets/blob/partner/src/tier0/dbg.cpp#L121
bool Plat_IsInDebugSession()
{
...
#elif IsPlaystation()
// NDA material << does not return any value
#elif IsNintendoSwitch()
return false;
#else
#error "HALP"
#endif
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/tier0/dbg.cpp at Plat_IsInDebugSession and inspect the IsPlaystation() preprocessor branch, then check the PS5 project configuration and available platform implementations. Confirm the replacement behavior with the PS5 build or tests, and consider the issue done when the function returns a defined result without introducing platform-specific build failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100