ValveSoftware / ValveSoftware/Fossilize

Add support for lists of shader hashes in fossilize-prune

Open
#296 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
780
Forks
78
PR merge metrics
No merged PRs in 30d

Description

I've used fossilize-prune a tiny bit and have continued to run into the relatively minor annoyance that when intending to prune to a list of shader hashes, the CLI currently requires re-specifying the filter argument for each hash, for example:

fossilize-prune --input-db Input.foz --output-db Output.foz --filter-graphics f2cb331235a3e518 --filter-graphics 0aeb4faec8c8575c ...

This can become incredibly unwieldy when attempting to prune beyond a very small number of shaders, would it be reasonable to see the CLI support listing hashes together, such as having a space or comma separating each hash?

I fully understand this is likely not to be a high priority at all, just has run into it enough to report it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at fossilize-prune's CLI argument parsing and the existing --filter-graphics handling. Determine how repeated filter arguments are processed, then add support for multiple hashes in one argument and verify that pruning accepts the listed hashes in a single invocation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.