ValeLang / ValeLang/Vale

Tech debt: consider removing EnvRuneLookupSR

Open
#331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2k
Forks
59
Avg merge
1m
Merged PRs (30d)
1

Description

It's how we encode into the rules that this particular rune should already be defined from the parent environment.

Well, to the rule system, it's all the same. In fact, it's an extra rule, so this is technically causing a little more work for the rule system. Perhaps if we had a map of these next to the rules, it would be faster/better?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating EnvRuneLookupSR and the rule system that consumes it, then trace how parent-environment definitions are represented. Determine whether a separate map can replace this extra rule without changing behavior; done means the redundant work is removed and the rule system still handles these definitions correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.