Vim window switching <C-w>-h/<C-w>-l stops working when clearing up ctrl+w ctrl+j key shortcut
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Clearing up ctrl+w ctrl+j binding also implicitly prohibits from switching between text editors with <C-w>-h/<C-w>-l. Ex
To Reproduce
Steps to reproduce the behavior:
- Open text editor with
keybindings.jsonand define it as
[
{
"key": "ctrl+w ctrl+j",
"command": "",
},
]
- Save changes to
keybindings.json - Enter
vimcommandvspto split the currentkeybindings.jsoninto 2 different text editors - Press
<C-w>-h/<C-w>-lto focus different text editors of recently openedkeybindings.json. - Notice
The key combination (Ctrl+W, L) is not a commandmessage.
Expected behavior
Clearing up ctrl+w ctrl+j binding should not affect the behavior of <C-w>-h way of switching between text editors.
Screenshots
Environment (please complete the following information):
- Extension (VsCodeVim) version: 1.27.2
- VSCode version: 1.85.1
- OS: Linux Ubuntu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the keybinding interaction in keybindings.json with the documented Vim split command, vsp. Trace the keybinding handling for clearing ctrl+w ctrl+j and verify that the change leaves ctrl+w-h and ctrl+w-l available for switching editors; done when both shortcuts work without the not-a-command message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- desktop-dev, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100