VSCodeVim / VSCodeVim/Vim

Vim window switching <C-w>-h/<C-w>-l stops working when clearing up ctrl+w ctrl+j key shortcut

Open
#8,833 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Clearing up ctrl+w ctrl+j binding also implicitly prohibits from switching between text editors with <C-w>-h/<C-w>-l. Ex

To Reproduce
Steps to reproduce the behavior:

  1. Open text editor with keybindings.json and define it as
[
    {
        "key": "ctrl+w ctrl+j",
        "command": "",
    },
]
  1. Save changes to keybindings.json
  2. Enter vim command vsp to split the current keybindings.json into 2 different text editors
  3. Press <C-w>-h/<C-w>-l to focus different text editors of recently opened keybindings.json.
  4. Notice The key combination (Ctrl+W, L) is not a command message.

Expected behavior
Clearing up ctrl+w ctrl+j binding should not affect the behavior of <C-w>-h way of switching between text editors.

Screenshots
vim

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.27.2
  • VSCode version: 1.85.1
  • OS: Linux Ubuntu

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the keybinding interaction in keybindings.json with the documented Vim split command, vsp. Trace the keybinding handling for clearing ctrl+w ctrl+j and verify that the change leaves ctrl+w-h and ctrl+w-l available for switching editors; done when both shortcuts work without the not-a-command message.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
desktop-dev, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.