<leader> key gets stuck when using <leader>m example with bookmarks.toggle
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Using the example for bookmarks remapping, the extension gets stuck in the key.
To Reproduce
Add to the settings.json file:
- Install bookmarks extension
- Add to the
settings.jsonfile
"vim.normalModeKeyBindings": [
{
"before": ["<leader>", "m"],
"commands": [
"bookmarks.toggle"
]
},
{
"before": ["<leader>", "b"],
"commands": [
"bookmarks.list"
]
}
]
- Try to place a mark using m
- The leader key now gets stuck (see status bar), and I can't exit back to normal/visual mode or anything, can't type or execute vim commands, so have to reload the window.
Expected behavior
Marks are toggled, can view the marks list
Screenshots
in the gif, once m is pressed, I type on all keys etc. but nothing happens
Environment (please complete the following information):
- Extension (VsCodeVim) version: v1.26.1
- VSCode version: 1.83.1
- OS: Windows 11 (running under WSL2)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the settings.json vim.normalModeKeyBindings example and the bookmarks.toggle command, then trace the keybinding handling for m and compare it with bookmarks.list. Done means toggling a bookmark no longer leaves the leader key active, and normal or visual mode commands work afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100