hlsearch re-enables in command mode
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
Similar to this issue
hlsearch is enabled when entering command mode.
To Reproduce
Steps to reproduce the behavior:
- Enter a search (
/foo<enter>) - Clear the highlighting (
:noh<enter>) - Enter command mode (
:) - Note that
foois re-highlighted.
Expected behavior
That hlsearch is not enabled in command mode
Screenshots
https://github.com/VSCodeVim/Vim/assets/16640287/6c7eb7ac-38b9-4eb9-a1ad-b4adbb8d4fb7
Environment (please complete the following information):
- Extension (VsCodeVim) version: 1.26.0
- VSCode version: Version: 1.82.2 (Universal)
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:59:47.790Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.5.0 - OS: Ventura
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by reproducing the sequence in VSCodeVim: search for foo, run :noh, then enter command mode. Trace the command-mode and hlsearch handling, and verify that foo remains unhighlighted after the sequence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100