VSCodeVim / VSCodeVim/Vim

Using when you have a settings.json file symbolically linked

Open
#8,539 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Every time I change mode when using your extension, it adds lines to the global settings.json to change the color of the bar of the workbench

To Reproduce

Install the extension.
Link the extension via symbolic link
Change the mode (then it will write to

Expected behavior
It dose not change global settings json file. Or does not change the settings file I have linked.

Those the files changes don't get tracked by git and accidentally added

  • Extension (VsCodeVim) version:
  • VSCode version:
Version: 1.81.1 (Universal)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:20:33.924Z (5 days ago)
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 22.5.0
macos 13.4.1 (c) (22F770820d)

Additional context
Seems strange that it writes to the global one and not the project or workspace one, although these two would normally be tracked by git. Although I can understand if downstream settings json get overridden.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code 1.81.1 on macOS with a symbolically linked settings.json, then locate the mode-change path that writes workbench bar colors to global settings. Done means changing mode no longer unexpectedly modifies the global or linked settings file, while the extension's intended color behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.