VSCodeVim / VSCodeVim/Vim

[BUG] All jump candidates are out of current window when there are too many positions to jump

Open
#8,441 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
All the positions with labels can jump to are above current window when use <leader><leader> s <char> and there are too many candidates to jump.

To Reproduce

  • write a document with many 'a' in it
  • move cursor to middle of the document
  • use <leader><leader> s a to search a
  • all candidates are above current window, and can not to jump any position you want

Expected behavior

All candidates should around current cursor, search for candidates with the minium distance to current cursor first, instead of from three windows above first.

Screenshots

Screenshot 2023-05-24 at 23 18 15

Extension version: 1.25.2
VS Code version: Code - Insiders 1.79.0-insider (f6be5461f8bc69013a605f5baea834651c6589fb, 2023-05-20T01:20:35.044Z)
OS version: Darwin x64 22.4.0
Modes:
Remote OS version: Linux x64 5.15.0-71-generic

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in the VS Code Vim extension by placing the cursor in the middle of a document with many matching characters and running s a. Trace the jump-candidate search behavior and verify that candidates are selected by minimum distance from the cursor, with all nearby positions remaining reachable.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.