VSCodeVim / VSCodeVim/Vim

fix indentation of current-line (=) stopped working

Open
#8,399 1 comment 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Previously, I was able to do fix-indentation with == in vscode with vim plugin.
This stopped working with latest vscode upgrade.

To Reproduce

  • Open code in any programming language and go to any line that is not indented correctly.
  • Press == to indent it. Nothing happens.
python_var = some_python_function(arg_a, arg_b, arg_c,
         arg_d)        #  == on this line should fix the indentation.

Expected behavior
Please see above.

  • Extension (VsCodeVim) version: v1.25.2
  • VSCode version:
Version: 1.77.3 (Universal)
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:19:37.325Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: Yes
  • OS: MAC OS

Additional context
Enabled keyboard shortcut trouble-shooting below is the output.

2023-04-27 18:18:36.273 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-27 18:18:36.305 [info] [KeybindingService]: | Resolving [Equal]
2023-04-27 18:18:36.305 [info] [KeybindingService]: \ No keybinding entries.
2023-04-27 18:18:36.305 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Equal, keyCode: 187, key: =
2023-04-27 18:18:36.305 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Equal, keyCode: 81 ('=')
2023-04-27 18:18:36.309 [info] [KeybindingService]: | Resolving [Equal]
2023-04-27 18:18:36.309 [info] [KeybindingService]: \ No keybinding entries.
2023-04-27 18:18:36.419 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-27 18:18:36.419 [info] [KeybindingService]: | Resolving [Equal]
2023-04-27 18:18:36.419 [info] [KeybindingService]: \ No keybinding entries.
2023-04-27 18:18:36.419 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Equal, keyCode: 187, key: =
2023-04-27 18:18:36.420 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Equal, keyCode: 81 ('=')
2023-04-27 18:18:36.420 [info] [KeybindingService]: | Resolving [Equal]
2023-04-27 18:18:36.420 [info] [KeybindingService]: \ No keybinding entries.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure in VSCodeVim v1.25.2 by opening a misindented file and pressing ==, then compare the keybinding troubleshooting output with the extension's handling of the Equal key. Done means == invokes fix-indentation again for the current line in supported language files.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vim, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.