Add an indicator when vim's find mode (i.e. when pressing`f`) is active
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Is your feature request related to a problem? Please describe.
I have mapped my editor to switch tabs backwards and forwards with the following:
{
"key": "shift+l",
"command": "workbench.action.nextEditor",
"when": "editorTextFocus && vim.mode != 'Insert'"
},
{
"key": "shift+h",
"command": "workbench.action.previousEditor",
"when": "editorTextFocus && vim.mode != 'Insert'"
},
this works pretty nicely in 99% of cases. But one problem I encountered if I want to find a captial "L" or "H" via fL and fH respectively as this activates the keybinding.
Describe the solution you'd like
And additional indicator, something like vim.findActive that can be used in the 'When expression' of a keybinding
Describe alternatives you've considered
I know this is a niche problem, and an alternative is simply rebidning to something different. But perhaps this would be a useful feature to have, since it would open another layer of keybindings that closely reflects common keybindings defined in other community projects (e.g. Lunarvim)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the extension represents Vim's find mode after pressing f and how vim.mode is exposed to VS Code when expressions. Review the keybinding examples in the issue and existing context-key handling. Done means a find-mode indicator is available for keybindings and behaves correctly while f/F searches are active.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100