Placeholders are not properly replaced
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
When using
{
"javascript.suggest.completeFunctionCalls": true
}
Placeholders in the completion are not properly replaced and will break the flow
Expected behavior
In the recording below, the keyword type loses its selection, what's expected is that the placeholder type should be replaced as soon as the user types.
Screenshots
https://user-images.githubusercontent.com/2827383/212486358-44fb90f7-1fcf-45fc-8346-45f30269a726.mp4
Environment (please complete the following information):
- Extension (VsCodeVim) version: 1.24.3
- VSCode : 1.74.3
- OS: Windows
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in VSCode 1.74.3 with javascript.suggest.completeFunctionCalls enabled, using the completion and typing sequence shown in the recording. Trace the extension's completion and placeholder handling to identify why the type selection is lost; done means the placeholder is replaced as soon as the user types without breaking the completion flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100