Marks are lost after doing an edit
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
A file mark is lost after doing any edit to the file.
To Reproduce
Steps to reproduce the behavior:
- On a file editor set a mark with
ma, for example. - Do any edit. For example,
oEsc. - When going to the mark with
'a, a 'Mark not set' message is shown on the status bar.
Expected behavior
The cursor should jump to where the mark was set.
Environment (please complete the following information):
- Extension (VsCodeVim) version: 1.24.3
- VSCode version: 1.74.2
- OS: Linux
Additional context
I don't use marks a lot, but I'd say this issue appeared with the VS Code upgrade to 1.74, so it may be related to #8157 and #8200.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce this in VSCodeVim 1.24.3 with VS Code 1.74.2 on Linux using ma, oEsc, and 'a. Then trace the mark-handling path and compare the behavior with #8157 and #8200; done means edits preserve the mark and 'a jumps to its location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100