VSCodeVim / VSCodeVim/Vim

'*' is not searching for whole word when '$' is removed from word separators

Open
#8,190 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
I'm developing in PHP so I have removed '$' from the word separators. When I perform a * search on a PHP variable that starts with a * it doesn't do a whole word search. It does a partial word match search.

To Reproduce
1.Remove $ from "editor.wordSeparators".
2. Then add a word $foo and $foobar to a file.
3. Perform a * search on $foo

Expected behavior
When performing a * search of $foo it should not find a match in $foobar.

Screenshots
image

Environment (please complete the following information):

  • Extension (VsCodeVim) version: v1.24.3
  • VSCode version: 1.74.2
  • OS: Windows 11 Pro

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by removing '$' from VS Code's editor.wordSeparators, adding $foo and $foobar, and searching for $foo with *. Trace the search handling for word boundaries; done means the search matches $foo but not the longer $foobar variable.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.