VSCodeVim / VSCodeVim/Vim

Global (uppercase) marks not restored in gutter after file closed/reopened

Open
#7,974 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
If I set an uppercase (global) mark on a line in a file, the gutter mark shows up fine. If I then close and re-open the file, navigating to the mark works, but the mark doesn't show up in the gutter.

To Reproduce
Steps to reproduce the behavior:

  1. Set an uppercase mark in a file (with mA for example)
  2. Close the file
  3. Navigate to the mark (with 'A for example)
  4. The file opens, but the mark is not visible in the gutter.

Expected behavior
When the file is opened, the extension should check for any global marks in the file and restore the marks in the gutter.

Screenshots

https://user-images.githubusercontent.com/702318/191122970-2b2043d5-ccce-4cc9-9aae-d767a914917f.mov

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.23.2
  • VSCode version: 1.71.2
  • OS: macOS 12.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the global-mark workflow in the VSCodeVim extension: set a mark, close and reopen the file, then navigate to it. Trace the gutter-mark restoration path when the file opens; done means the mark is visible in the gutter after reopening.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.