VSCodeVim / VSCodeVim/Vim

A sequence of undone changes cannot be redone past the last one

Open
#7,896 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
A sequence of undone changes cannot be redone past the last one. Possible data loss.

To Reproduce
Steps to reproduce the behavior:

  1. Make some changes
  2. Undo 5 times with u
  3. Redo 5 times with ctrl+r
  4. Only the first redo (of the last undo) works

Expected behavior
All undone changes are re-applied.

Screenshots

Environment (please complete the following information):

  • Extension (VsCodeVim) version: v1.23.2
  • VSCode version: 1.71.0-insider b0895f9
  • OS: macOS

Additional context

  • Sometimes it works, but when it doesn’t it’s a data loss scenario unless the file was saved before the undo took place.
  • A few days ago I had to re-write a couple dozen LoC from memory due to this bug.
  • Didn’t happen until the last time I let VSC and extension upgrade themselves. Now it happens every day many times.
  • Increasing undo history to 500+ didn’t help.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in VSCodeVim with u and ctrl+r, using the versions and macOS environment listed in the report. Trace the extension's undo and redo handling to determine why only the first of five redos succeeds. Done means five consecutive undos can all be followed by five successful redos without losing changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.