VSCodeVim / VSCodeVim/Vim

Configuring ctrl+w ctrl+j affects another bindings

Open
#7,748 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Adding binding ctrl+w ctrl+j to swtich between text editor and visible panel makes vscodevim not working.

To Reproduce

  1. Open 2 text editor panels

  2. Set your keybindings.json file to be

[
    {
        "key": "ctrl+w ctrl+j",
        "command": "workbench.action.focusPanel",
        "when": "editorFocus && panelVisible"
    }
]
  1. Try to switch from the left text editor to the right text editor and see the error
    The key combination (CTRL+W, L) is not a command

Expected behavior
Adding such a keybinding should not affect vim way of switching between text editors.
Note that removing this binding makes vscodevim work as expected.

Screenshots
Screenshot from 2022-06-08 22-17-58

Screenshot from 2022-06-08 22-13-27

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.22.2
  • VSCode version: 1.67.2
  • OS: Ubuntu 20.04

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the conflict using the keybindings.json entry shown, with VSCodeVim 1.22.2 on the reported VS Code and Ubuntu versions, then compare behavior after removing that binding. Trace how the Ctrl+W sequence is handled by the extension and VS Code keybindings; done means the custom binding still focuses the panel without changing VSCodeVim editor-switching behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.