VSCodeVim / VSCodeVim/Vim

Status Bar Color Control doesn't reset its styles when unchecked

Open
#7,648 3 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
Vim: Status Bar Color Control works by overwriting workbench.colorCustomizations in the user's settings.json but it fails to reset those modifications after I turn it off by unchecking the option in vscode settings.

"workbench.colorCustomizations": {
"statusBar.background": "#005f5f",
"statusBar.noFolderBackground": "#005f5f",
"statusBar.debuggingBackground": "#005f5f"
},
^This was not removed from my settings.json, which made the ugly color persist on every color theme after trying out the Status Bar Color Control setting.

To Reproduce
Steps to reproduce the behavior:

  1. Check the Status Bar Color Control setting
  2. See your settings.json being overwritten in real time when using the setting
  3. Turn off the Status Bar Color Control setting
  4. Get stuck with the last status bar color set by VSCodeVim on every color theme until you manually delete the offending part of your settings.json

Expected behavior
Status bar color returns to current color theme's default upon turning this functionality off

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.22.2
  • VSCode version: 1.66.2
  • OS: Windows 10 Pro

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Status Bar Color Control setting and the code that writes workbench.colorCustomizations to settings.json. Reproduce the toggle sequence, then verify that unchecking removes the colors written by this feature and restores the current theme's defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.