VSCodeVim / VSCodeVim/Vim

Failed to handle key `s`: Cannot read property 'start' of undefined

Open
#7,563 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

VSCodeVim version: 1.22.2

Stack trace
TypeError: Failed to handle key `s`: Cannot read property 'start' of undefined
    at t.SearchByCharCommand.exec (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\actions\plugins\easymotion\easymotion.cmd.ts:82:70)
    at t.SearchByCharCommand.fire (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\actions\plugins\easymotion\easymotion.cmd.ts:169:16)
    at g.exec (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\actions\plugins\easymotion\easymotion.cmd.ts:335:20)
    at runMicrotasks (<anonymous>)
    at process.j (internal/process/task_queues.js:93:5)
    at g.execCount (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\actions\base.ts:229:42)
    at j.actionToRecord [as runAction] (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\mode\modeHandler.ts:714:47)
    at j.handledAsAction [as handleKeyAsAnAction] (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\mode\modeHandler.ts:663:43)
    at j.text [as handleKeyEvent] (c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\src\mode\modeHandler.ts:478:11)
    at c:\Users\nd\.vscode\extensions\vscodevim.vim-1.22.2\extensionBase.ts:359:73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/actions/plugins/easymotion/easymotion.cmd.ts, especially SearchByCharCommand.exec at the stack-trace location around line 82. Reproduce the reported key s failure in VSCodeVim 1.22.2, then trace the undefined value and verify that handling the key no longer throws the reported TypeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.