VSCodeVim / VSCodeVim/Vim

Error message for `:q` in dirty file is incorrect

Open
#7,544 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
TypeScript
Stars
15.2k
Forks
1.5k
Avg merge
3d 18h
Merged PRs (30d)
6

Description

Describe the bug
:q! is a command to finish editing without saving. However, the error message says to use this command to override it, which is a mistake for :wq.

To Reproduce
Steps to reproduce the behavior:

  1. Enter :q in file with unsaved changes.

Expected behavior
This message need to change to No write since change (add w to overwrite)

Screenshots
スクリーンショット 2022-03-09 17 43 33

Environment (please complete the following information):

  • Extension (VsCodeVim) version: latest
  • VSCode version: latest
  • OS: macos Montery

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the command-handling entry point for :q when the file has unsaved changes. Reproduce the behavior by entering :q in a dirty file, then update the incorrect message so it says "No write since change (add w to overwrite)" and verify that :q! remains the command for exiting without saving.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.