Easymotion Dim Color only applies to incremental search
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 6
Description
Describe the bug
While setting the Easymotion Dim Color affects the text color for an Easymotion Incremental Search, it does not affect the text color when jumping to a word or otherwise selecting which match to jump to. It seems that this setting should apply to both situations.
To Reproduce
Steps to reproduce the behavior:
- Turn on Easymotion and Easymotion Dim Background.
- Set an obvious, custom Easymotion Dim Color, such as #00ff00.
- Press
<leader><leader>/to begin an incremental search and observe that the text turns green. - Type to search for some text in the buffer and press enter. Observe that the text background color returns to the default #777777.
Expected behavior
Easymotion Dim Color affects jump location selection.
Screenshots
Environment:
- Extension (VsCodeVim) version: 1.22.2
- VSCode version: 1.64.2
- OS: Windows 10 build 19044
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in VSCodeVim 1.22.2 using Easymotion Dim Background, a custom Easymotion Dim Color, incremental search, and direct word selection. Trace the color handling for both selection paths; done when the custom color is preserved during jump-location selection as well as incremental search.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100